Updated threex.domevent.js#34
Open
JoeBonham wants to merge 1 commit intojeromeetienne:masterfrom
JoeBonham:patch-1
Open
Updated threex.domevent.js#34JoeBonham wants to merge 1 commit intojeromeetienne:masterfrom JoeBonham:patch-1
JoeBonham wants to merge 1 commit intojeromeetienne:masterfrom
JoeBonham:patch-1
Conversation
Integrated THREE.domevent with THREE.Object3D as domevent will not work as expected without it. Updated a few function calls to ensure compatibility with newer versions of ThreeJS (Credit for this: http://learningthreejs.com/blog/2012/01/17/dom-events-in-3d-space/#comment-802169267). Updated the read me at the top of the page to reference the need to use: THREE.Object3D._threexDomEvent.camera(CAMERA_VAR) before setting up any events.
|
I reviewed his code and these are nearly identical changes to the ones I made to get mine to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated
threex.domeventwiththreex.domevent.object3dasthreex.domeventwill not work as expected without it.Updated a few function calls to ensure compatibility with newer versions of ThreeJS (Credit: http://learningthreejs.com/blog/2012/01/17/dom-events-in-3d-space/#comment-802169267)
Updated the read me at the top of the page to reference the need to use:
THREE.Object3D._threexDomEvent.camera(CAMERA_VAR)before setting up any events.